From: mar77i <mar77i@protonmail.ch>
Date: Sun, 22 Mar 2026 16:03:19 +0000 (+0100)
Subject: perftrace_children, perftrace_recursive: no need to pass more than a pid_t
X-Git-Url: https://git.mar77i.info/?a=commitdiff_plain;h=1ed85149683d37e5624c322d242a593ca904c7cd;p=perftrace

perftrace_children, perftrace_recursive: no need to pass more than a pid_t
---

diff --git a/perftrace.c b/perftrace.c
index 1af5435..20eddb7 100644
--- a/perftrace.c
+++ b/perftrace.c
@@ -305,7 +305,7 @@ static inline int perftrace_pid(
 }
 
 static inline int perftrace_children(
-    struct pid_item item,
+    pid_t pid,
     struct list new,
     struct list *old,
     struct timespec diff,
@@ -314,7 +314,7 @@ static inline int perftrace_children(
 ) {
     struct pid_item *ptr;
     for (ptr = new.data; LIST_POS(ptr, new, struct pid_item) < new.len; ptr++) {
-        if (ptr->ppid != item.pid)
+        if (ptr->ppid != pid)
             continue;
         if (perftrace_pid(*ptr, old, diff, humanize_mem, json_state) < 0)
             return -1;
@@ -337,7 +337,7 @@ static inline pid_t *perftrace_find_pid(struct list found_pids, pid_t pid) {
 }
 
 static inline int perftrace_recursive(
-    struct pid_item item,
+    pid_t pid,
     struct list new,
     struct list *old,
     struct timespec diff,
@@ -351,7 +351,7 @@ static inline int perftrace_recursive(
     int ret = 0;
     if (list_maybe_grow(&found_pids, ++found_pids.len, sizeof (pid_t)) < 0)
         return -1;
-    *LIST_AT(found_pids, 0, pid_t) = item.pid;
+    *LIST_AT(found_pids, 0, pid_t) = pid;
     do {
         last_found = found;
         for (
@@ -440,12 +440,12 @@ static inline int perftrace(
             (
                 arg_pid->mode == '+'
                 && perftrace_children(
-                    *item, new, old, diff, humanize_mem, json_state
+                    arg_pid->pid, new, old, diff, humanize_mem, json_state
                 ) < 0
             ) || (
                 arg_pid->mode == '*'
                 && perftrace_recursive(
-                    *item, new, old, diff, humanize_mem, json_state
+                    arg_pid->pid, new, old, diff, humanize_mem, json_state
                 ) < 0
             )
         )